Fix handling of node-format when output-format-type is set #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current behavior is that if output-format-type is set node-format is ignored. This includes the case where output-format-type is set in a config file, so if your config file sets a default format it's impossible to override it on the command line. One solution is to avoid setting a default output format in config files. While that works, it's worth noting unidic-mecab's default config file includes a default output format. If someone tries to use node-format without being aware of this they might just think it doesn't work. This change makes it so that if node-format is explicitly set output-format-type is ignored. If output-format-type isn't used behavior is unchanged; this only changes things when output-format-type and node-format are both set. -POLM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
taku910#38
Current behavior is that if output-format-type is set node-format is
ignored. This includes the case where output-format-type is set in a
config file, so if your config file sets a default format it's
impossible to override it on the command line.
One solution is to avoid setting a default output format in config
files. While that works, it's worth noting unidic-mecab's default config
file includes a default output format. If someone tries to use
node-format without being aware of this they might just think it doesn't
work.
This change makes it so that if node-format is explicitly set
output-format-type is ignored. If output-format-type isn't used behavior
is unchanged; this only changes things when output-format-type and
node-format are both set. -POLM